Skip to content

Commit 8974573

Browse files
Malaya Kumar Routrafaeljw
authored andcommitted
ACPI: tools: pfrut: fix memory leak and resource leak in pfrut.c
Static analysis found an issue in pfrut.c cppcheck output before this patch: tools/power/acpi/tools/pfrut/pfrut.c:225:3: error: Resource leak: fd_update [resourceLeak] tools/power/acpi/tools/pfrut/pfrut.c:269:3: error: Resource leak: fd_update [resourceLeak] tools/power/acpi/tools/pfrut/pfrut.c:269:3: error: Resource leak: fd_update_log [resourceLeak] tools/power/acpi/tools/pfrut/pfrut.c:365:4: error: Memory leak: addr_map_capsule [memleak] tools/power/acpi/tools/pfrut/pfrut.c:424:4: error: Memory leak: log_buf [memleak] cppcheck output after this patch: No resource leaks found Fix by closing file descriptors and freeing allocated memory. Signed-off-by: Malaya Kumar Rout <mrout@redhat.com> Link: https://patch.msgid.link/20251120170001.251968-1-mrout@redhat.com Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent ac3fd01 commit 8974573

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

  • tools/power/acpi/tools/pfrut

tools/power/acpi/tools/pfrut/pfrut.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,7 @@ int main(int argc, char *argv[])
222222
fd_update_log = open("/dev/acpi_pfr_telemetry0", O_RDWR);
223223
if (fd_update_log < 0) {
224224
printf("PFRT device not supported - Quit...\n");
225+
close(fd_update);
225226
return 1;
226227
}
227228

@@ -265,7 +266,8 @@ int main(int argc, char *argv[])
265266
printf("chunk2_size:%d\n", data_info.chunk2_size);
266267
printf("rollover_cnt:%d\n", data_info.rollover_cnt);
267268
printf("reset_cnt:%d\n", data_info.reset_cnt);
268-
269+
close(fd_update);
270+
close(fd_update_log);
269271
return 0;
270272
}
271273

@@ -358,6 +360,7 @@ int main(int argc, char *argv[])
358360

359361
if (ret == -1) {
360362
perror("Failed to load capsule file");
363+
munmap(addr_map_capsule, st.st_size);
361364
close(fd_capsule);
362365
close(fd_update);
363366
close(fd_update_log);
@@ -420,7 +423,7 @@ int main(int argc, char *argv[])
420423
if (p_mmap == MAP_FAILED) {
421424
perror("mmap error.");
422425
close(fd_update_log);
423-
426+
free(log_buf);
424427
return 1;
425428
}
426429

0 commit comments

Comments
 (0)