regulator: core: Remove redundant ternary operators

LiaoYuanhong-vivo · broonie · commit 899fb38dd76d · 2025-08-28T16:02:51.000+02:00
For ternary operators in the form of "a ? true : false", if 'a' itself
returns a boolean result, the ternary operator can be omitted. Remove
redundant ternary operators to clean up the code.

Signed-off-by: Liao Yuanhong &lt;liaoyuanhong@vivo.com&gt;
Message-ID: &lt;20250828122737.43488-1-liaoyuanhong@vivo.com&gt;
Signed-off-by: Mark Brown &lt;broonie@kernel.org&gt;
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
@@ -1586,8 +1586,8 @@ static int set_machine_constraints(struct regulator_dev *rdev)
 	}
 
 	if (rdev->constraints->active_discharge && ops->set_active_discharge) {
-		bool ad_state = (rdev->constraints->active_discharge ==
-			      REGULATOR_ACTIVE_DISCHARGE_ENABLE) ? true : false;
+		bool ad_state = rdev->constraints->active_discharge ==
+			      REGULATOR_ACTIVE_DISCHARGE_ENABLE;
 
 		ret = ops->set_active_discharge(rdev, ad_state);
 		if (ret < 0) {

Original file line number	Diff line number	Diff line change
`@@ -1586,8 +1586,8 @@ static int set_machine_constraints(struct regulator_dev *rdev)`
`1586`	`1586`	`}`
`1587`	`1587`
`1588`	`1588`	`if (rdev->constraints->active_discharge && ops->set_active_discharge) {`
`1589`		`- bool ad_state = (rdev->constraints->active_discharge ==`
`1590`		`- REGULATOR_ACTIVE_DISCHARGE_ENABLE) ? true : false;`
	`1589`	`+ bool ad_state = rdev->constraints->active_discharge ==`
	`1590`	`+ REGULATOR_ACTIVE_DISCHARGE_ENABLE;`
`1591`	`1591`
`1592`	`1592`	`ret = ops->set_active_discharge(rdev, ad_state);`
`1593`	`1593`	`if (ret < 0) {`