ARM: OMAP2+: Remove the unneeded result variable

ye xingchen · tmlind · commit 89e990559c37 · 2023-03-28T08:44:28.000+03:00
Return the value amx3_common_init() directly instead of storing it in
another redundant variable.

Reported-by: Zeal Robot &lt;zealci@zte.com.cn&gt;
Signed-off-by: ye xingchen &lt;ye.xingchen@zte.com.cn&gt;
Message-Id: &lt;20220920065113.215685-1-ye.xingchen@zte.com.cn&gt;
Signed-off-by: Tony Lindgren &lt;tony@atomide.com&gt;
diff --git a/arch/arm/mach-omap2/pm33xx-core.c b/arch/arm/mach-omap2/pm33xx-core.c
@@ -104,18 +104,14 @@ static int amx3_common_init(int (*idle)(u32 wfi_flags))
 
 static int am33xx_suspend_init(int (*idle)(u32 wfi_flags))
 {
-	int ret;
-
 	gfx_l4ls_clkdm = clkdm_lookup("gfx_l4ls_gfx_clkdm");
 
 	if (!gfx_l4ls_clkdm) {
 		pr_err("PM: Cannot lookup gfx_l4ls_clkdm clockdomains\n");
 		return -ENODEV;
 	}
 
-	ret = amx3_common_init(idle);
-
-	return ret;
+	return amx3_common_init(idle);
 }
 
 static int am43xx_suspend_init(int (*idle)(u32 wfi_flags))

Original file line number	Diff line number	Diff line change
`@@ -104,18 +104,14 @@ static int amx3_common_init(int (*idle)(u32 wfi_flags))`
`104`	`104`
`105`	`105`	`static int am33xx_suspend_init(int (*idle)(u32 wfi_flags))`
`106`	`106`	`{`
`107`		`- int ret;`
`108`		`-`
`109`	`107`	`gfx_l4ls_clkdm = clkdm_lookup("gfx_l4ls_gfx_clkdm");`
`110`	`108`
`111`	`109`	`if (!gfx_l4ls_clkdm) {`
`112`	`110`	`pr_err("PM: Cannot lookup gfx_l4ls_clkdm clockdomains\n");`
`113`	`111`	`return -ENODEV;`
`114`	`112`	`}`
`115`	`113`
`116`		`- ret = amx3_common_init(idle);`
`117`		`-`
`118`		`- return ret;`
	`114`	`+ return amx3_common_init(idle);`
`119`	`115`	`}`
`120`	`116`
`121`	`117`	`static int am43xx_suspend_init(int (*idle)(u32 wfi_flags))`