Skip to content

Commit 8a157e0

Browse files
author
Andreas Gruenbacher
committed
gfs2: Fix use of bio_chain
In gfs2_chain_bio(), the call to bio_chain() has its arguments swapped. The result is leaked bios and incorrect synchronization (only the last bio will actually be waited for). This code is only used during mount and filesystem thaw, so the bug normally won't be noticeable. Reported-by: Stephen Zhang <starzhangzsd@gmail.com> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
1 parent 8334890 commit 8a157e0

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

fs/gfs2/lops.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,7 @@ static struct bio *gfs2_chain_bio(struct bio *prev, unsigned int nr_iovecs)
484484
new = bio_alloc(prev->bi_bdev, nr_iovecs, prev->bi_opf, GFP_NOIO);
485485
bio_clone_blkg_association(new, prev);
486486
new->bi_iter.bi_sector = bio_end_sector(prev);
487-
bio_chain(new, prev);
487+
bio_chain(prev, new);
488488
submit_bio(prev);
489489
return new;
490490
}

0 commit comments

Comments
 (0)