Skip to content

Commit 8a3e634

Browse files
Zhengqiao Xiadtor
authored andcommitted
HID: google: modify HID device groups of eel
If HID_GROUP of eel is set to HID_GROUP_GENERIC, Whiskers Tablet Mode Switch of eel hammer will not be detected by system because the hid-vivaldi driver probes the device. When it is set to HID_GROUP_VIVALDI, system will detect Whiskers Tablet Mode Switch successfully and also support the vivaldi keyboard layout. Tested-by: "Sean O'Brien" <seobrien@chromium.org> Acked-by: Jiri Kosina <jkosina@suse.cz> Signed-off-by: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com> [swboyd@chromium.org: Expand on commit text] Signed-off-by: Stephen Boyd <swboyd@chromium.org> Tested-by: Stephen Boyd <swboyd@chromium.org> # coachz, wormdingler Link: https://lore.kernel.org/r/20220228075446.466016-6-dmitry.torokhov@gmail.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
1 parent a9d6729 commit 8a3e634

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/hid/hid-google-hammer.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -582,7 +582,7 @@ static void hammer_remove(struct hid_device *hdev)
582582
static const struct hid_device_id hammer_devices[] = {
583583
{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
584584
USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_DON) },
585-
{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
585+
{ HID_DEVICE(BUS_USB, HID_GROUP_VIVALDI,
586586
USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_EEL) },
587587
{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
588588
USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_HAMMER) },

0 commit comments

Comments
 (0)