mtd: rawnand: marvell: ensure timing values are written

cpackham-atlnz · miquelraynal · commit 8a6f4d346f3b · 2023-06-01T18:12:32.000+02:00
When new timing values are calculated in marvell_nfc_setup_interface() ensure that they will be applied in marvell_nfc_select_target() by clearing the selected_chip pointer. Fixes: b252514 ("mtd: rawnand: marvell: Stop implementing ->select_chip()") Suggested-by: Miquel Raynal <miquel.raynal@bootlin.com> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20230525003154.2303012-1-chris.packham@alliedtelesis.co.nz
diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c
@@ -2457,6 +2457,12 @@ static int marvell_nfc_setup_interface(struct nand_chip *chip, int chipnr,
 			NDTR1_WAIT_MODE;
 	}
 
+	/*
+	 * Reset nfc->selected_chip so the next command will cause the timing
+	 * registers to be updated in marvell_nfc_select_target().
+	 */
+	nfc->selected_chip = NULL;
+
 	return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -2457,6 +2457,12 @@ static int marvell_nfc_setup_interface(struct nand_chip *chip, int chipnr,`
`2457`	`2457`	`NDTR1_WAIT_MODE;`
`2458`	`2458`	`}`
`2459`	`2459`
	`2460`	`+ /*`
	`2461`	`+ * Reset nfc->selected_chip so the next command will cause the timing`
	`2462`	`+ * registers to be updated in marvell_nfc_select_target().`
	`2463`	`+ */`
	`2464`	`+ nfc->selected_chip = NULL;`
	`2465`	`+`
`2460`	`2466`	`return 0;`
`2461`	`2467`	`}`
`2462`	`2468`