Skip to content

Commit 8a8792f

Browse files
shakeelbtorvalds
authored andcommitted
mm: memcg: fix memcg file_dirty numa stat
The kernel updates the per-node NR_FILE_DIRTY stats on page migration but not the memcg numa stats. That was not an issue until recently the commit 5f9a4f4 ("mm: memcontrol: add the missing numa_stat interface for cgroup v2") exposed numa stats for the memcg. So fix the file_dirty per-memcg numa stat. Link: https://lkml.kernel.org/r/20210108155813.2914586-1-shakeelb@google.com Fixes: 5f9a4f4 ("mm: memcontrol: add the missing numa_stat interface for cgroup v2") Signed-off-by: Shakeel Butt <shakeelb@google.com> Reviewed-by: Muchun Song <songmuchun@bytedance.com> Acked-by: Yang Shi <shy828301@gmail.com> Reviewed-by: Roman Gushchin <guro@fb.com> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: Michal Hocko <mhocko@kernel.org> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 3de7d4f commit 8a8792f

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

mm/migrate.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -500,9 +500,9 @@ int migrate_page_move_mapping(struct address_space *mapping,
500500
__inc_lruvec_state(new_lruvec, NR_SHMEM);
501501
}
502502
if (dirty && mapping_can_writeback(mapping)) {
503-
__dec_node_state(oldzone->zone_pgdat, NR_FILE_DIRTY);
503+
__dec_lruvec_state(old_lruvec, NR_FILE_DIRTY);
504504
__dec_zone_state(oldzone, NR_ZONE_WRITE_PENDING);
505-
__inc_node_state(newzone->zone_pgdat, NR_FILE_DIRTY);
505+
__inc_lruvec_state(new_lruvec, NR_FILE_DIRTY);
506506
__inc_zone_state(newzone, NR_ZONE_WRITE_PENDING);
507507
}
508508
}

0 commit comments

Comments
 (0)