firmware: arm_scmi: Clean up a return statement in scmi_probe

error27 · sudeep-holla · commit 8ab5059dc4f4 · 2023-03-06T08:42:32.000Z
The comments say "enabled" where "disabled" is intended. Also it's cleaner to return zero explicitly instead of ret. Signed-off-by: Dan Carpenter <error27@gmail.com> Link: https://lore.kernel.org/r/Y86im5M49p3ePGxj@kili Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
@@ -2739,8 +2739,8 @@ static int scmi_probe(struct platform_device *pdev)
 				if (ret)
 					goto clear_dev_req_notifier;
 
-				/* Bail out anyway when coex enabled */
-				return ret;
+				/* Bail out anyway when coex disabled. */
+				return 0;
 			}
 
 			/* Coex enabled, carry on in any case. */

Original file line number	Diff line number	Diff line change
`@@ -2739,8 +2739,8 @@ static int scmi_probe(struct platform_device *pdev)`
`2739`	`2739`	`if (ret)`
`2740`	`2740`	`goto clear_dev_req_notifier;`
`2741`	`2741`
`2742`		`- /* Bail out anyway when coex enabled */`
`2743`		`- return ret;`
	`2742`	`+ /* Bail out anyway when coex disabled. */`
	`2743`	`+ return 0;`
`2744`	`2744`	`}`
`2745`	`2745`
`2746`	`2746`	`/* Coex enabled, carry on in any case. */`