Skip to content

Commit 8b05e7d

Browse files
Andrew Jonespalmer-dabbelt
authored andcommitted
RISC-V: Factor out body of riscv_init_cbom_blocksize loop
Refactor riscv_init_cbom_blocksize() to prepare for it to be used for both cbom block size and cboz block size. Signed-off-by: Andrew Jones <ajones@ventanamicro.com> Reviewed-by: Heiko Stuebner <heiko@sntech.de> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Link: https://lore.kernel.org/r/20230224162631.405473-3-ajones@ventanamicro.com Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
1 parent 0b2f658 commit 8b05e7d

1 file changed

Lines changed: 25 additions & 20 deletions

File tree

arch/riscv/mm/cacheflush.c

Lines changed: 25 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -100,34 +100,39 @@ void flush_icache_pte(pte_t pte)
100100
unsigned int riscv_cbom_block_size;
101101
EXPORT_SYMBOL_GPL(riscv_cbom_block_size);
102102

103+
static void cbo_get_block_size(struct device_node *node,
104+
const char *name, u32 *block_size,
105+
unsigned long *first_hartid)
106+
{
107+
unsigned long hartid;
108+
u32 val;
109+
110+
if (riscv_of_processor_hartid(node, &hartid))
111+
return;
112+
113+
if (of_property_read_u32(node, name, &val))
114+
return;
115+
116+
if (!*block_size) {
117+
*block_size = val;
118+
*first_hartid = hartid;
119+
} else if (*block_size != val) {
120+
pr_warn("%s mismatched between harts %lu and %lu\n",
121+
name, *first_hartid, hartid);
122+
}
123+
}
124+
103125
void riscv_init_cbom_blocksize(void)
104126
{
105127
struct device_node *node;
106128
unsigned long cbom_hartid;
107-
u32 val, probed_block_size;
108-
int ret;
129+
u32 probed_block_size;
109130

110131
probed_block_size = 0;
111132
for_each_of_cpu_node(node) {
112-
unsigned long hartid;
113-
114-
ret = riscv_of_processor_hartid(node, &hartid);
115-
if (ret)
116-
continue;
117-
118133
/* set block-size for cbom extension if available */
119-
ret = of_property_read_u32(node, "riscv,cbom-block-size", &val);
120-
if (ret)
121-
continue;
122-
123-
if (!probed_block_size) {
124-
probed_block_size = val;
125-
cbom_hartid = hartid;
126-
} else {
127-
if (probed_block_size != val)
128-
pr_warn("cbom-block-size mismatched between harts %lu and %lu\n",
129-
cbom_hartid, hartid);
130-
}
134+
cbo_get_block_size(node, "riscv,cbom-block-size",
135+
&probed_block_size, &cbom_hartid);
131136
}
132137

133138
if (probed_block_size)

0 commit comments

Comments
 (0)