fbdev: imx: Constify lcd_ops

krzk · lag-linaro · commit 8b2d4564eca4 · 2024-05-03T10:45:46.000+01:00
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Peng Fan <peng.fan@nxp.com> Link: https://lore.kernel.org/r/20240424-video-backlight-lcd-ops-v2-17-1aaa82b07bc6@kernel.org Signed-off-by: Lee Jones <lee@kernel.org>
diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
@@ -857,7 +857,7 @@ static int imxfb_lcd_set_power(struct lcd_device *lcddev, int power)
 	return 0;
 }
 
-static struct lcd_ops imxfb_lcd_ops = {
+static const struct lcd_ops imxfb_lcd_ops = {
 	.check_fb	= imxfb_lcd_check_fb,
 	.get_contrast	= imxfb_lcd_get_contrast,
 	.set_contrast	= imxfb_lcd_set_contrast,

Original file line number	Diff line number	Diff line change
`@@ -857,7 +857,7 @@ static int imxfb_lcd_set_power(struct lcd_device *lcddev, int power)`
`857`	`857`	`return 0;`
`858`	`858`	`}`
`859`	`859`
`860`		`-static struct lcd_ops imxfb_lcd_ops = {`
	`860`	`+static const struct lcd_ops imxfb_lcd_ops = {`
`861`	`861`	`.check_fb = imxfb_lcd_check_fb,`
`862`	`862`	`.get_contrast = imxfb_lcd_get_contrast,`
`863`	`863`	`.set_contrast = imxfb_lcd_set_contrast,`