scsi: mpt3sas: Signedness bug in _base_get_diag_triggers()

Dan Carpenter · martinkpetersen · commit 8b3c8035297e · 2020-12-09T11:57:39.000-05:00
The "trigger_flags" variable needs to be signed for the error checking to work. Link: https://lore.kernel.org/r/X9DZH37bYPHwSQRP@mwanda Fixes: aec93e8 ("scsi: mpt3sas: Add persistent trigger pages support") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@ -5027,7 +5027,7 @@ _base_check_for_trigger_pages_support(struct MPT3SAS_ADAPTER *ioc)
 static void
 _base_get_diag_triggers(struct MPT3SAS_ADAPTER *ioc)
 {
-	u16 trigger_flags;
+	int trigger_flags;
 
 	/*
 	 * Default setting of master trigger.

Original file line number	Diff line number	Diff line change
`@@ -5027,7 +5027,7 @@ _base_check_for_trigger_pages_support(struct MPT3SAS_ADAPTER *ioc)`
`5027`	`5027`	`static void`
`5028`	`5028`	`_base_get_diag_triggers(struct MPT3SAS_ADAPTER *ioc)`
`5029`	`5029`	`{`
`5030`		`- u16 trigger_flags;`
	`5030`	`+ int trigger_flags;`
`5031`	`5031`
`5032`	`5032`	`/*`
`5033`	`5033`	`* Default setting of master trigger.`