Skip to content

Commit 8b997b2

Browse files
harshimogalapallijgross1
authored andcommitted
xen/privcmd: Fix a possible warning in privcmd_ioctl_mmap_resource()
As 'kdata.num' is user-controlled data, if user tries to allocate memory larger than(>=) MAX_ORDER, then kcalloc() will fail, it creates a stack trace and messes up dmesg with a warning. Call trace: -> privcmd_ioctl --> privcmd_ioctl_mmap_resource Add __GFP_NOWARN in order to avoid too large allocation warning. This is detected by static analysis using smatch. Fixes: 3ad0876 ("xen/privcmd: add IOCTL_PRIVCMD_MMAP_RESOURCE") Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> Reviewed-by: Juergen Gross <jgross@suse.com> Link: https://lore.kernel.org/r/20221126050745.778967-1-harshit.m.mogalapalli@oracle.com Signed-off-by: Juergen Gross <jgross@suse.com>
1 parent ca84ce1 commit 8b997b2

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/xen/privcmd.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -760,7 +760,7 @@ static long privcmd_ioctl_mmap_resource(struct file *file,
760760
goto out;
761761
}
762762

763-
pfns = kcalloc(kdata.num, sizeof(*pfns), GFP_KERNEL);
763+
pfns = kcalloc(kdata.num, sizeof(*pfns), GFP_KERNEL | __GFP_NOWARN);
764764
if (!pfns) {
765765
rc = -ENOMEM;
766766
goto out;

0 commit comments

Comments
 (0)