Skip to content

Commit 8bf3ea7

Browse files
committed
hid/picolcd: Remove flag FBINFO_FLAG_DEFAULT from fbdev driver
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix commit message (Miguel) Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Acked-by: Sam Ravnborg <sam@ravnborg.org> Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Acked-by: Bruno Prémont <bonbons@linux-vserver.org> Cc: "Bruno Prémont" <bonbons@linux-vserver.org> Cc: Jiri Kosina <jikos@kernel.org> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-11-tzimmermann@suse.de
1 parent 8920157 commit 8bf3ea7

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

drivers/hid/hid-picolcd_fb.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,6 @@ int picolcd_init_framebuffer(struct picolcd_data *data)
527527
info->var = picolcdfb_var;
528528
info->fix = picolcdfb_fix;
529529
info->fix.smem_len = PICOLCDFB_SIZE*8;
530-
info->flags = FBINFO_FLAG_DEFAULT;
531530

532531
fbdata = info->par;
533532
spin_lock_init(&fbdata->lock);

0 commit comments

Comments
 (0)