Skip to content

Commit 8cbd727

Browse files
committed
ASoC: mt6358: Remove undefined HPx Mux enumeration values
The HPx Mux enumerations define values 5, 6 and 7 but describe them as "undefined" and map them to the value 0 on writing. Given the descriptions and behaviour it seems that these values are invalid and should not be present in the register, the current behaviour is detected as problematic by mixer-test: # # HPL Mux.0 expected 5 but read 0, is_volatile 0 # # HPL Mux.0 expected 6 but read 0, is_volatile 0 # # HPL Mux.0 expected 7 but read 0, is_volatile 0 Remove the values from the enumeration, this will prevent userspace setting them. Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Signed-off-by: Mark Brown <broonie@kernel.org> Link: https://lore.kernel.org/r/20230224-asoc-mt6358-quick-fixes-v1-3-747d9186be4b@kernel.org Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 8e847a4 commit 8cbd727

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

sound/soc/codecs/mt6358.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -637,9 +637,6 @@ static const char * const hp_in_mux_map[] = {
637637
"Audio Playback",
638638
"Test Mode",
639639
"HP Impedance",
640-
"undefined1",
641-
"undefined2",
642-
"undefined3",
643640
};
644641

645642
static int hp_in_mux_map_value[] = {
@@ -648,9 +645,6 @@ static int hp_in_mux_map_value[] = {
648645
HP_MUX_HP,
649646
HP_MUX_TEST_MODE,
650647
HP_MUX_HP_IMPEDANCE,
651-
HP_MUX_OPEN,
652-
HP_MUX_OPEN,
653-
HP_MUX_OPEN,
654648
};
655649

656650
static SOC_VALUE_ENUM_SINGLE_DECL(hpl_in_mux_map_enum,

0 commit comments

Comments
 (0)