Skip to content

Commit 8ce5ace

Browse files
charleskeepaxbroonie
authored andcommitted
ASoC: sdw_utils: Remove num_platforms from simple DAI helper
There is no point in passing num_platforms into asoc_sdw_init_simple_dai_link(). Firstly, as a single pointer for the component name is passed in only a single string can be passed and secondly if it is a complex DAI with multiple platforms it would make more sense to use asoc_sdw_init_dai_link(). Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> Link: https://patch.msgid.link/20250505141409.2614010-2-ckeepax@opensource.cirrus.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 92a09c4 commit 8ce5ace

5 files changed

Lines changed: 8 additions & 16 deletions

File tree

include/sound/soc_sdw_utils.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,8 @@ void asoc_sdw_init_dai_link(struct device *dev, struct snd_soc_dai_link *dai_lin
159159
int asoc_sdw_init_simple_dai_link(struct device *dev, struct snd_soc_dai_link *dai_links,
160160
int *be_id, char *name, int playback, int capture,
161161
const char *cpu_dai_name, const char *platform_comp_name,
162-
int num_platforms, const char *codec_name,
163-
const char *codec_dai_name, int no_pcm,
164-
int (*init)(struct snd_soc_pcm_runtime *rtd),
162+
const char *codec_name, const char *codec_dai_name,
163+
int no_pcm, int (*init)(struct snd_soc_pcm_runtime *rtd),
165164
const struct snd_soc_ops *ops);
166165

167166
int asoc_sdw_count_sdw_endpoints(struct snd_soc_card *card, int *num_devs, int *num_ends);

sound/soc/amd/acp/acp-sdw-legacy-mach.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ static int create_dmic_dailinks(struct snd_soc_card *card,
321321
*be_id = ACP_DMIC_BE_ID;
322322
ret = asoc_sdw_init_simple_dai_link(dev, *dai_links, be_id, "acp-dmic-codec",
323323
0, 1, // DMIC only supports capture
324-
pdm_cpu->name, pdm_platform->name, 1,
324+
pdm_cpu->name, pdm_platform->name,
325325
"dmic-codec.0", "dmic-hifi", no_pcm,
326326
asoc_sdw_dmic_init, NULL);
327327
if (ret)

sound/soc/amd/acp/acp-sdw-sof-mach.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,6 @@ static int create_dmic_dailinks(struct snd_soc_card *card,
245245
ret = asoc_sdw_init_simple_dai_link(dev, *dai_links, be_id, "acp-dmic-codec",
246246
0, 1, // DMIC only supports capture
247247
"acp-sof-dmic", platform_component->name,
248-
ARRAY_SIZE(platform_component),
249248
"dmic-codec", "dmic-hifi", no_pcm,
250249
asoc_sdw_dmic_init, NULL);
251250
if (ret)

sound/soc/intel/boards/sof_sdw.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -994,8 +994,7 @@ static int create_ssp_dailinks(struct snd_soc_card *card,
994994

995995
ret = asoc_sdw_init_simple_dai_link(dev, *dai_links, be_id, name,
996996
playback, capture, cpu_dai_name,
997-
platform_component->name,
998-
ARRAY_SIZE(platform_component), codec_name,
997+
platform_component->name, codec_name,
999998
ssp_info->dais[0].dai_name, 1, NULL,
1000999
ssp_info->ops);
10011000
if (ret)
@@ -1020,7 +1019,6 @@ static int create_dmic_dailinks(struct snd_soc_card *card,
10201019
ret = asoc_sdw_init_simple_dai_link(dev, *dai_links, be_id, "dmic01",
10211020
0, 1, // DMIC only supports capture
10221021
"DMIC01 Pin", platform_component->name,
1023-
ARRAY_SIZE(platform_component),
10241022
"dmic-codec", "dmic-hifi", 1,
10251023
asoc_sdw_dmic_init, NULL);
10261024
if (ret)
@@ -1031,7 +1029,6 @@ static int create_dmic_dailinks(struct snd_soc_card *card,
10311029
ret = asoc_sdw_init_simple_dai_link(dev, *dai_links, be_id, "dmic16k",
10321030
0, 1, // DMIC only supports capture
10331031
"DMIC16k Pin", platform_component->name,
1034-
ARRAY_SIZE(platform_component),
10351032
"dmic-codec", "dmic-hifi", 1,
10361033
/* don't call asoc_sdw_dmic_init() twice */
10371034
NULL, NULL);
@@ -1075,7 +1072,6 @@ static int create_hdmi_dailinks(struct snd_soc_card *card,
10751072
ret = asoc_sdw_init_simple_dai_link(dev, *dai_links, be_id, name,
10761073
1, 0, // HDMI only supports playback
10771074
cpu_dai_name, platform_component->name,
1078-
ARRAY_SIZE(platform_component),
10791075
codec_name, codec_dai_name, 1,
10801076
i == 0 ? sof_sdw_hdmi_init : NULL, NULL);
10811077
if (ret)
@@ -1102,7 +1098,6 @@ static int create_bt_dailinks(struct snd_soc_card *card,
11021098

11031099
ret = asoc_sdw_init_simple_dai_link(dev, *dai_links, be_id, name,
11041100
1, 1, cpu_dai_name, platform_component->name,
1105-
ARRAY_SIZE(platform_component),
11061101
snd_soc_dummy_dlc.name, snd_soc_dummy_dlc.dai_name,
11071102
1, NULL, NULL);
11081103
if (ret)

sound/soc/sdw_utils/soc_sdw_utils.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1059,9 +1059,8 @@ EXPORT_SYMBOL_NS(asoc_sdw_init_dai_link, "SND_SOC_SDW_UTILS");
10591059
int asoc_sdw_init_simple_dai_link(struct device *dev, struct snd_soc_dai_link *dai_links,
10601060
int *be_id, char *name, int playback, int capture,
10611061
const char *cpu_dai_name, const char *platform_comp_name,
1062-
int num_platforms, const char *codec_name,
1063-
const char *codec_dai_name, int no_pcm,
1064-
int (*init)(struct snd_soc_pcm_runtime *rtd),
1062+
const char *codec_name, const char *codec_dai_name,
1063+
int no_pcm, int (*init)(struct snd_soc_pcm_runtime *rtd),
10651064
const struct snd_soc_ops *ops)
10661065
{
10671066
struct snd_soc_dai_link_component *dlc;
@@ -1078,8 +1077,8 @@ int asoc_sdw_init_simple_dai_link(struct device *dev, struct snd_soc_dai_link *d
10781077
dlc[2].dai_name = codec_dai_name;
10791078

10801079
asoc_sdw_init_dai_link(dev, dai_links, be_id, name, playback, capture,
1081-
&dlc[0], 1, &dlc[1], num_platforms,
1082-
&dlc[2], 1, no_pcm, init, ops);
1080+
&dlc[0], 1, &dlc[1], 1, &dlc[2], 1,
1081+
no_pcm, init, ops);
10831082

10841083
return 0;
10851084
}

0 commit comments

Comments
 (0)