Skip to content

Commit 8d470a4

Browse files
guilhermepiccolitorvalds
authored andcommitted
panic: add option to dump all CPUs backtraces in panic_print
Currently the "panic_print" parameter/sysctl allows some interesting debug information to be printed during a panic event. This is useful for example in cases the user cannot kdump due to resource limits, or if the user collects panic logs in a serial output (or pstore) and prefers a fast reboot instead of a kdump. Happens that currently there's no way to see all CPUs backtraces in a panic using "panic_print" on architectures that support that. We do have "oops_all_cpu_backtrace" sysctl, but although partially overlapping in the functionality, they are orthogonal in nature: "panic_print" is a panic tuning (and we have panics without oopses, like direct calls to panic() or maybe other paths that don't go through oops_enter() function), and the original purpose of "oops_all_cpu_backtrace" is to provide more information on oopses for cases in which the users desire to continue running the kernel even after an oops, i.e., used in non-panic scenarios. So, we hereby introduce an additional bit for "panic_print" to allow dumping the CPUs backtraces during a panic event. Link: https://lkml.kernel.org/r/20211109202848.610874-3-gpiccoli@igalia.com Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com> Reviewed-by: Feng Tang <feng.tang@intel.com> Cc: Iurii Zaikin <yzaikin@google.com> Cc: Kees Cook <keescook@chromium.org> Cc: Luis Chamberlain <mcgrof@kernel.org> Cc: Samuel Iglesias Gonsalvez <siglesias@igalia.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent a1ff1de commit 8d470a4

3 files changed

Lines changed: 6 additions & 0 deletions

File tree

Documentation/admin-guide/kernel-parameters.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3726,6 +3726,7 @@
37263726
bit 3: print locks info if CONFIG_LOCKDEP is on
37273727
bit 4: print ftrace buffer
37283728
bit 5: print all printk messages in buffer
3729+
bit 6: print all CPUs backtrace (if available in the arch)
37293730

37303731
panic_on_taint= Bitmask for conditionally calling panic() in add_taint()
37313732
Format: <hex>[,nousertaint]

Documentation/admin-guide/sysctl/kernel.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -796,6 +796,7 @@ bit 2 print timer info
796796
bit 3 print locks info if ``CONFIG_LOCKDEP`` is on
797797
bit 4 print ftrace buffer
798798
bit 5 print all printk messages in buffer
799+
bit 6 print all CPUs backtrace (if available in the arch)
799800
===== ============================================
800801

801802
So for example to print tasks and memory info on panic, user can::

kernel/panic.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ EXPORT_SYMBOL_GPL(panic_timeout);
6666
#define PANIC_PRINT_LOCK_INFO 0x00000008
6767
#define PANIC_PRINT_FTRACE_INFO 0x00000010
6868
#define PANIC_PRINT_ALL_PRINTK_MSG 0x00000020
69+
#define PANIC_PRINT_ALL_CPU_BT 0x00000040
6970
unsigned long panic_print;
7071

7172
ATOMIC_NOTIFIER_HEAD(panic_notifier_list);
@@ -152,6 +153,9 @@ static void panic_print_sys_info(void)
152153
if (panic_print & PANIC_PRINT_ALL_PRINTK_MSG)
153154
console_flush_on_panic(CONSOLE_REPLAY_ALL);
154155

156+
if (panic_print & PANIC_PRINT_ALL_CPU_BT)
157+
trigger_all_cpu_backtrace();
158+
155159
if (panic_print & PANIC_PRINT_TASK_INFO)
156160
show_state();
157161

0 commit comments

Comments
 (0)