RISC-V: Remove redundant err variable

Minghao Chi · palmer-dabbelt · commit 8da46c0f98a1 · 2022-01-20T10:24:12.000-08:00
Return value from user_regset_copyin() directly instead of taking this
in another redundant variable.

Reported-by: Zeal Robot &lt;zealci@zte.com.cn&gt;
Signed-off-by: Minghao Chi &lt;chi.minghao@zte.com.cn&gt;
Signed-off-by: CGEL ZTE &lt;cgel.zte@gmail.com&gt;
Signed-off-by: Palmer Dabbelt &lt;palmer@rivosinc.com&gt;
diff --git a/arch/riscv/kernel/ptrace.c b/arch/riscv/kernel/ptrace.c
@@ -42,12 +42,10 @@ static int riscv_gpr_set(struct task_struct *target,
 			 unsigned int pos, unsigned int count,
 			 const void *kbuf, const void __user *ubuf)
 {
-	int ret;
 	struct pt_regs *regs;
 
 	regs = task_pt_regs(target);
-	ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf, regs, 0, -1);
-	return ret;
+	return user_regset_copyin(&pos, &count, &kbuf, &ubuf, regs, 0, -1);
 }
 
 #ifdef CONFIG_FPU

Original file line number	Diff line number	Diff line change
`@@ -42,12 +42,10 @@ static int riscv_gpr_set(struct task_struct *target,`
`42`	`42`	`unsigned int pos, unsigned int count,`
`43`	`43`	`const void kbuf, const void __user ubuf)`
`44`	`44`	`{`
`45`		`- int ret;`
`46`	`45`	`struct pt_regs *regs;`
`47`	`46`
`48`	`47`	`regs = task_pt_regs(target);`
`49`		`- ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf, regs, 0, -1);`
`50`		`- return ret;`
	`48`	`+ return user_regset_copyin(&pos, &count, &kbuf, &ubuf, regs, 0, -1);`
`51`	`49`	`}`
`52`	`50`
`53`	`51`	`#ifdef CONFIG_FPU`