Skip to content

Commit 8e925de

Browse files
sipragadavem330
authored andcommitted
net: dsa: realtek: don't parse compatible string for RTL8366S
This switch is not even supported, but if someone were to actually put this compatible string "realtek,rtl8366s" in their device tree, they would be greeted with a kernel panic because the probe function would dereference NULL. So let's just remove it. Link: https://lore.kernel.org/all/CACRpkdYdKZs0WExXc3=0yPNOwP+oOV60HRz7SRoGjZvYHaT=1g@mail.gmail.com/ Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 2511e0c commit 8e925de

1 file changed

Lines changed: 0 additions & 5 deletions

File tree

drivers/net/dsa/realtek/realtek-smi.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -546,11 +546,6 @@ static const struct of_device_id realtek_smi_of_match[] = {
546546
.data = &rtl8366rb_variant,
547547
},
548548
#endif
549-
{
550-
/* FIXME: add support for RTL8366S and more */
551-
.compatible = "realtek,rtl8366s",
552-
.data = NULL,
553-
},
554549
#if IS_ENABLED(CONFIG_NET_DSA_REALTEK_RTL8365MB)
555550
{
556551
.compatible = "realtek,rtl8365mb",

0 commit comments

Comments
 (0)