Skip to content

Commit 8f7cc63

Browse files
tititiou36vinodkoul
authored andcommitted
dmaengine: qcom_hidma: Remove useless DMA-32 fallback configuration
As stated in [1], dma_set_mask() with a 64-bit mask never fails if dev->dma_mask is non-NULL. So, if it fails, the 32 bits case will also fail for the same reason. Simplify code and remove some dead code accordingly. [1]: https://lore.kernel.org/linux-kernel/YL3vSPK5DXTNvgdx@infradead.org/#t Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Link: https://lore.kernel.org/r/4deb32b0c7838da66608022c584326eb01d0da03.1642232106.git.christophe.jaillet@wanadoo.fr Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent 386fe06 commit 8f7cc63

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

drivers/dma/qcom/hidma.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -838,9 +838,7 @@ static int hidma_probe(struct platform_device *pdev)
838838
rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
839839
if (rc) {
840840
dev_warn(&pdev->dev, "unable to set coherent mask to 64");
841-
rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
842-
if (rc)
843-
goto dmafree;
841+
goto dmafree;
844842
}
845843

846844
dmadev->lldev = hidma_ll_init(dmadev->ddev.dev,

0 commit comments

Comments
 (0)