Skip to content

Commit 8ffd6c2

Browse files
Uwe Kleine-Königbebarino
authored andcommitted
clk: palmas: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230312161512.2715500-13-u.kleine-koenig@pengutronix.de Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent 601b2f1 commit 8ffd6c2

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

drivers/clk/clk-palmas.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -271,10 +271,9 @@ static int palmas_clks_probe(struct platform_device *pdev)
271271
return ret;
272272
}
273273

274-
static int palmas_clks_remove(struct platform_device *pdev)
274+
static void palmas_clks_remove(struct platform_device *pdev)
275275
{
276276
of_clk_del_provider(pdev->dev.of_node);
277-
return 0;
278277
}
279278

280279
static struct platform_driver palmas_clks_driver = {
@@ -283,7 +282,7 @@ static struct platform_driver palmas_clks_driver = {
283282
.of_match_table = palmas_clks_of_match,
284283
},
285284
.probe = palmas_clks_probe,
286-
.remove = palmas_clks_remove,
285+
.remove_new = palmas_clks_remove,
287286
};
288287

289288
module_platform_driver(palmas_clks_driver);

0 commit comments

Comments
 (0)