Skip to content

Commit 9049572

Browse files
committed
hwmon: Remove amd_energy driver
Commit 60268b0 ("hwmon: (amd_energy) modify the visibility of the counters") restricted visibility of AMD energy counters to work around a side-channel attack using energy data to determine which instructions are executed. The attack is described in 'PLATYPUS: Software-based Power Side-Channel Attacks on x86'. It relies on quick and accurate energy readings. This change made the counters provided by the amd_energy driver effectively unusable for non-provileged users. However, unprivileged read access is the whole point of hardware monitoring attributes. An attempt to remedy the situation by limiting and randomizing access to chip registers was rejected by AMD. Since the driver is for all practical purposes unusable, remove it. Cc: Naveen Krishna Chatradhi <nchatrad@amd.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent e157639 commit 9049572

5 files changed

Lines changed: 0 additions & 516 deletions

File tree

Documentation/hwmon/amd_energy.rst

Lines changed: 0 additions & 119 deletions
This file was deleted.

Documentation/hwmon/index.rst

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ Hardware Monitoring Kernel Drivers
3939
adt7475
4040
aht10
4141
amc6821
42-
amd_energy
4342
asb100
4443
asc7621
4544
aspeed-pwm-tacho

MAINTAINERS

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -870,13 +870,6 @@ S: Supported
870870
T: git git://people.freedesktop.org/~agd5f/linux
871871
F: drivers/gpu/drm/amd/display/
872872

873-
AMD ENERGY DRIVER
874-
M: Naveen Krishna Chatradhi <nchatrad@amd.com>
875-
L: linux-hwmon@vger.kernel.org
876-
S: Maintained
877-
F: Documentation/hwmon/amd_energy.rst
878-
F: drivers/hwmon/amd_energy.c
879-
880873
AMD FAM15H PROCESSOR POWER MONITORING DRIVER
881874
M: Huang Rui <ray.huang@amd.com>
882875
L: linux-hwmon@vger.kernel.org

drivers/hwmon/Kconfig

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -321,16 +321,6 @@ config SENSORS_FAM15H_POWER
321321
This driver can also be built as a module. If so, the module
322322
will be called fam15h_power.
323323

324-
config SENSORS_AMD_ENERGY
325-
tristate "AMD RAPL MSR based Energy driver"
326-
depends on X86
327-
help
328-
If you say yes here you get support for core and package energy
329-
sensors, based on RAPL MSR for AMD family 17h and above CPUs.
330-
331-
This driver can also be built as a module. If so, the module
332-
will be called as amd_energy.
333-
334324
config SENSORS_APPLESMC
335325
tristate "Apple SMC (Motion sensor, light sensor, keyboard backlight)"
336326
depends on INPUT && X86

0 commit comments

Comments
 (0)