Skip to content

Commit 90f3c12

Browse files
gal-pressmanakpm00
authored andcommitted
panic: only warn about deprecated panic_print on write access
The panic_print_deprecated() warning is being triggered on both read and write operations to the panic_print parameter. This causes spurious warnings when users run 'sysctl -a' to list all sysctl values, since that command reads /proc/sys/kernel/panic_print and triggers the deprecation notice. Modify the handlers to only emit the deprecation warning when the parameter is actually being set: - sysctl_panic_print_handler(): check 'write' flag before warning. - panic_print_get(): remove the deprecation call entirely. This way, users are only warned when they actively try to use the deprecated parameter, not when passively querying system state. Link: https://lkml.kernel.org/r/20260106163321.83586-1-gal@nvidia.com Fixes: ee13240 ("panic: add note that panic_print sysctl interface is deprecated") Fixes: 2683df6 ("panic: add note that 'panic_print' parameter is deprecated") Signed-off-by: Gal Pressman <gal@nvidia.com> Reviewed-by: Mark Bloch <mbloch@nvidia.com> Reviewed-by: Nimrod Oren <noren@nvidia.com> Cc: Feng Tang <feng.tang@linux.alibaba.com> Cc: Joel Granados <joel.granados@kernel.org> Cc: Petr Mladek <pmladek@suse.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent f9a49aa commit 90f3c12

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

kernel/panic.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,8 @@ static int proc_taint(const struct ctl_table *table, int write,
131131
static int sysctl_panic_print_handler(const struct ctl_table *table, int write,
132132
void *buffer, size_t *lenp, loff_t *ppos)
133133
{
134-
panic_print_deprecated();
134+
if (write)
135+
panic_print_deprecated();
135136
return proc_doulongvec_minmax(table, write, buffer, lenp, ppos);
136137
}
137138

@@ -1014,7 +1015,6 @@ static int panic_print_set(const char *val, const struct kernel_param *kp)
10141015

10151016
static int panic_print_get(char *val, const struct kernel_param *kp)
10161017
{
1017-
panic_print_deprecated();
10181018
return param_get_ulong(val, kp);
10191019
}
10201020

0 commit comments

Comments
 (0)