Skip to content

Commit 9123157

Browse files
Mani-Sadhasivambjorn-helgaas
authored andcommitted
PCI: qcom-ep: Disable resources unconditionally during PERST# assert
All EP specific resources are enabled during PERST# deassert. As a counter operation, all resources should be disabled during PERST# assert. There is no point in skipping that if the link was not enabled. This will also result in enablement of the resources twice if PERST# got deasserted again. So remove the check from qcom_pcie_perst_assert() and disable all the resources unconditionally. Fixes: f55fee5 ("PCI: qcom-ep: Add Qualcomm PCIe Endpoint controller driver") Link: https://lore.kernel.org/linux-pci/20240430-pci-epf-rework-v4-1-22832d0d456f@linaro.org Tested-by: Niklas Cassel <cassel@kernel.org> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Niklas Cassel <cassel@kernel.org>
1 parent c71b5eb commit 9123157

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

drivers/pci/controller/dwc/pcie-qcom-ep.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -521,12 +521,6 @@ static int qcom_pcie_perst_deassert(struct dw_pcie *pci)
521521
static void qcom_pcie_perst_assert(struct dw_pcie *pci)
522522
{
523523
struct qcom_pcie_ep *pcie_ep = to_pcie_ep(pci);
524-
struct device *dev = pci->dev;
525-
526-
if (pcie_ep->link_status == QCOM_PCIE_EP_LINK_DISABLED) {
527-
dev_dbg(dev, "Link is already disabled\n");
528-
return;
529-
}
530524

531525
dw_pcie_ep_cleanup(&pci->ep);
532526
qcom_pcie_disable_resources(pcie_ep);

0 commit comments

Comments
 (0)