Skip to content

Commit 913cd76

Browse files
committed
svcrdma: Remove pointer addresses shown in dprintk()
There are a couple of dprintk() call sites in svc_rdma_accept() that show pointer addresses. These days, displayed pointer addresses are hashed and thus have little or no diagnostic value, especially for site administrators. Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent 2a95ce4 commit 913cd76

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

net/sunrpc/xprtrdma/svc_rdma_transport.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -457,8 +457,6 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt *xprt)
457457
qp_attr.qp_type = IB_QPT_RC;
458458
qp_attr.send_cq = newxprt->sc_sq_cq;
459459
qp_attr.recv_cq = newxprt->sc_rq_cq;
460-
dprintk("svcrdma: newxprt->sc_cm_id=%p, newxprt->sc_pd=%p\n",
461-
newxprt->sc_cm_id, newxprt->sc_pd);
462460
dprintk(" cap.max_send_wr = %d, cap.max_recv_wr = %d\n",
463461
qp_attr.cap.max_send_wr, qp_attr.cap.max_recv_wr);
464462
dprintk(" cap.max_send_sge = %d, cap.max_recv_sge = %d\n",
@@ -512,7 +510,7 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt *xprt)
512510
}
513511

514512
#if IS_ENABLED(CONFIG_SUNRPC_DEBUG)
515-
dprintk("svcrdma: new connection %p accepted:\n", newxprt);
513+
dprintk("svcrdma: new connection accepted on device %s:\n", dev->name);
516514
sap = (struct sockaddr *)&newxprt->sc_cm_id->route.addr.src_addr;
517515
dprintk(" local address : %pIS:%u\n", sap, rpc_get_port(sap));
518516
sap = (struct sockaddr *)&newxprt->sc_cm_id->route.addr.dst_addr;

0 commit comments

Comments
 (0)