drm/appletbdrm: Fix ref-counting on dmadev

tdz · tdz · commit 914ee6e730e1 · 2025-03-10T10:54:24.000+01:00
Remove the put_device() call on dmadev. The driver sets the field without getting a reference, so it shouldn't put a reference either. The dmadev field points to the regular USB device for which DRM maintains a reference internally. Hence dmadev will not become dangling during the DRM device's lifetime. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Fixes: 0670c2f ("drm/tiny: add driver for Apple Touch Bars in x86 Macs") Cc: Aditya Garg <gargaditya08@live.com> Cc: Aun-Ali Zaidi <admin@kodeit.net> Cc: dri-devel@lists.freedesktop.org Acked-by: Aditya Garg <gargaditya08@live.com> Link: https://patchwork.freedesktop.org/patch/msgid/20250307083702.142675-1-tzimmermann@suse.de
diff --git a/drivers/gpu/drm/tiny/appletbdrm.c b/drivers/gpu/drm/tiny/appletbdrm.c
@@ -805,7 +805,6 @@ static void appletbdrm_disconnect(struct usb_interface *intf)
 	struct appletbdrm_device *adev = usb_get_intfdata(intf);
 	struct drm_device *drm = &adev->drm;
 
-	put_device(adev->dmadev);
 	drm_dev_unplug(drm);
 	drm_atomic_helper_shutdown(drm);
 }

Original file line number	Diff line number	Diff line change
`@@ -805,7 +805,6 @@ static void appletbdrm_disconnect(struct usb_interface *intf)`
`805`	`805`	`struct appletbdrm_device *adev = usb_get_intfdata(intf);`
`806`	`806`	`struct drm_device *drm = &adev->drm;`
`807`	`807`
`808`		`- put_device(adev->dmadev);`
`809`	`808`	`drm_dev_unplug(drm);`
`810`	`809`	`drm_atomic_helper_shutdown(drm);`
`811`	`810`	`}`