Skip to content

Commit 91510d5

Browse files
author
Bartosz Golaszewski
committed
gpio: cdev: fix a NULL-pointer dereference with DEBUG enabled
We are actually passing the gc pointer to chip_dbg() so we have to srcu_dereference() it. Fixes: 8574b5b ("gpio: cdev: use correct pointer accessors with SRCU") Reported-by: Marek Szyprowski <m.szyprowski@samsung.com> Closes: https://lore.kernel.org/lkml/179caa10-5f86-4707-8bb0-fe1b316326d6@samsung.com/ Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
1 parent 8ff0d55 commit 91510d5

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/gpio/gpiolib-cdev.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2795,8 +2795,8 @@ int gpiolib_cdev_register(struct gpio_device *gdev, dev_t devt)
27952795
return ret;
27962796

27972797
guard(srcu)(&gdev->srcu);
2798-
2799-
if (!rcu_access_pointer(gdev->chip))
2798+
gc = srcu_dereference(gdev->chip, &gdev->srcu);
2799+
if (!gc)
28002800
return -ENODEV;
28012801

28022802
chip_dbg(gc, "added GPIO chardev (%d:%d)\n", MAJOR(devt), gdev->id);

0 commit comments

Comments
 (0)