Skip to content

Commit 9187d55

Browse files
stephan-ghandersson
authored andcommitted
arm64: dts: qcom: msm8939: Fix regulator constraints
The regulator constraints for the MSM8939 devices were originally taken from Qualcomm's msm-3.10 vendor device tree (for lack of better documentation). Unfortunately it turns out that Qualcomm's voltages are slightly off as well and do not match the voltage constraints applied by the RPM firmware. This means that we sometimes request a specific voltage but the RPM firmware actually applies a much lower or higher voltage. This is particularly critical for pm8916_l11 which is used as SD card VMMC regulator: The SD card can choose a voltage from the current range of 1.8 - 2.95V. If it chooses to run at 1.8V we pretend that this is fine but the RPM firmware will still silently end up configuring 2.95V. This can be easily reproduced with a multimeter or by checking the SPMI hardware registers of the regulator. Apply the same change as for MSM8916 in commit 3557508 ("arm64: dts: qcom: msm8916: Fix regulator constraints") and make the voltages match the actual "specified range" in the PM8916 Device Specification which is enforced by the RPM firmware. Signed-off-by: Stephan Gerhold <stephan@gerhold.net> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> Signed-off-by: Bjorn Andersson <andersson@kernel.org> Link: https://lore.kernel.org/r/20230530-msm8939-regulators-v1-5-a3c3ac833567@gerhold.net
1 parent 8771308 commit 9187d55

2 files changed

Lines changed: 12 additions & 12 deletions

File tree

arch/arm64/boot/dts/qcom/apq8039-t2.dts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -164,13 +164,13 @@
164164
vdd_l7-supply = <&pm8916_s4>;
165165

166166
pm8916_s3: s3 {
167-
regulator-min-microvolt = <1200000>;
168-
regulator-max-microvolt = <1300000>;
167+
regulator-min-microvolt = <1250000>;
168+
regulator-max-microvolt = <1350000>;
169169
};
170170

171171
pm8916_s4: s4 {
172-
regulator-min-microvolt = <1800000>;
173-
regulator-max-microvolt = <2100000>;
172+
regulator-min-microvolt = <1850000>;
173+
regulator-max-microvolt = <2150000>;
174174
};
175175

176176
/* l1 is fixed to 1225000, but not connected in schematic */
@@ -201,7 +201,7 @@
201201
};
202202

203203
pm8916_l8: l8 {
204-
regulator-min-microvolt = <2850000>;
204+
regulator-min-microvolt = <2900000>;
205205
regulator-max-microvolt = <2900000>;
206206
};
207207

@@ -216,7 +216,7 @@
216216
};
217217

218218
pm8916_l11: l11 {
219-
regulator-min-microvolt = <1800000>;
219+
regulator-min-microvolt = <2950000>;
220220
regulator-max-microvolt = <2950000>;
221221
};
222222

arch/arm64/boot/dts/qcom/msm8939-sony-xperia-kanuti-tulip.dts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -64,13 +64,13 @@
6464
vdd_l7-supply = <&pm8916_s4>;
6565

6666
pm8916_s3: s3 {
67-
regulator-min-microvolt = <1200000>;
68-
regulator-max-microvolt = <1300000>;
67+
regulator-min-microvolt = <1250000>;
68+
regulator-max-microvolt = <1350000>;
6969
};
7070

7171
pm8916_s4: s4 {
72-
regulator-min-microvolt = <1800000>;
73-
regulator-max-microvolt = <2100000>;
72+
regulator-min-microvolt = <1850000>;
73+
regulator-max-microvolt = <2150000>;
7474
};
7575

7676
pm8916_l2: l2 {
@@ -99,7 +99,7 @@
9999
};
100100

101101
pm8916_l8: l8 {
102-
regulator-min-microvolt = <2850000>;
102+
regulator-min-microvolt = <2900000>;
103103
regulator-max-microvolt = <2900000>;
104104
};
105105

@@ -114,7 +114,7 @@
114114
};
115115

116116
pm8916_l11: l11 {
117-
regulator-min-microvolt = <1800000>;
117+
regulator-min-microvolt = <2950000>;
118118
regulator-max-microvolt = <2950000>;
119119
regulator-system-load = <200000>;
120120
regulator-allow-set-load;

0 commit comments

Comments
 (0)