Skip to content

Commit 91ba8de

Browse files
committed
ACPI: scan: Do not mark button ACPI devices as wakeup-capable
It is generally questionable to mark struct acpi_device "devices" as wakeup-capable because they represent firmware entities that by themselves have no wakeup capabilities. It was done for struct acpi_device "devices" corresponding to buttons because the ACPI button driver was binding to them directly, but now that corresponding platform devices are created for the buttons and they are marked as wakeup-capable by the ACPI button driver, there is no reason to continue doing it. Update acpi_wakeup_gpe_init() accordingly. Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Link: https://patch.msgid.link/2891119.BEx9A2HvPv@rafael.j.wysocki
1 parent 2cf321e commit 91ba8de

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

drivers/acpi/scan.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1023,7 +1023,6 @@ static bool acpi_wakeup_gpe_init(struct acpi_device *device)
10231023
wakeup->sleep_state == ACPI_STATE_S5)
10241024
wakeup->sleep_state = ACPI_STATE_S4;
10251025
acpi_mark_gpe_for_wake(wakeup->gpe_device, wakeup->gpe_number);
1026-
device_set_wakeup_capable(&device->dev, true);
10271026
return true;
10281027
}
10291028

0 commit comments

Comments
 (0)