Skip to content

Commit 922181a

Browse files
committed
drm/i915: use intel_connector in intel_connector_debugfs_add()
Prefer struct intel_connector over struct drm_connector. Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20231205134143.2427661-1-jani.nikula@intel.com
1 parent 261200e commit 922181a

1 file changed

Lines changed: 26 additions & 27 deletions

File tree

drivers/gpu/drm/i915/display/intel_display_debugfs.c

Lines changed: 26 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1566,59 +1566,58 @@ DEFINE_SHOW_ATTRIBUTE(intel_crtc_pipe);
15661566

15671567
/**
15681568
* intel_connector_debugfs_add - add i915 specific connector debugfs files
1569-
* @intel_connector: pointer to a registered drm_connector
1569+
* @connector: pointer to a registered intel_connector
15701570
*
15711571
* Cleanup will be done by drm_connector_unregister() through a call to
15721572
* drm_debugfs_connector_remove().
15731573
*/
1574-
void intel_connector_debugfs_add(struct intel_connector *intel_connector)
1574+
void intel_connector_debugfs_add(struct intel_connector *connector)
15751575
{
1576-
struct drm_connector *connector = &intel_connector->base;
1577-
struct dentry *root = connector->debugfs_entry;
1578-
struct drm_i915_private *dev_priv = to_i915(connector->dev);
1576+
struct drm_i915_private *i915 = to_i915(connector->base.dev);
1577+
struct dentry *root = connector->base.debugfs_entry;
1578+
int connector_type = connector->base.connector_type;
15791579

15801580
/* The connector must have been registered beforehands. */
15811581
if (!root)
15821582
return;
15831583

1584-
intel_drrs_connector_debugfs_add(intel_connector);
1585-
intel_psr_connector_debugfs_add(intel_connector);
1584+
intel_drrs_connector_debugfs_add(connector);
1585+
intel_psr_connector_debugfs_add(connector);
15861586

1587-
if (connector->connector_type == DRM_MODE_CONNECTOR_eDP)
1587+
if (connector_type == DRM_MODE_CONNECTOR_eDP)
15881588
debugfs_create_file("i915_panel_timings", S_IRUGO, root,
1589-
connector, &i915_panel_fops);
1589+
&connector->base, &i915_panel_fops);
15901590

1591-
if (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
1592-
connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
1593-
connector->connector_type == DRM_MODE_CONNECTOR_HDMIB) {
1591+
if (connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
1592+
connector_type == DRM_MODE_CONNECTOR_HDMIA ||
1593+
connector_type == DRM_MODE_CONNECTOR_HDMIB) {
15941594
debugfs_create_file("i915_hdcp_sink_capability", S_IRUGO, root,
1595-
connector, &i915_hdcp_sink_capability_fops);
1595+
&connector->base, &i915_hdcp_sink_capability_fops);
15961596
}
15971597

1598-
if (DISPLAY_VER(dev_priv) >= 11 &&
1599-
((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort &&
1600-
!to_intel_connector(connector)->mst_port) ||
1601-
connector->connector_type == DRM_MODE_CONNECTOR_eDP)) {
1598+
if (DISPLAY_VER(i915) >= 11 &&
1599+
((connector_type == DRM_MODE_CONNECTOR_DisplayPort && !connector->mst_port) ||
1600+
connector_type == DRM_MODE_CONNECTOR_eDP)) {
16021601
debugfs_create_file("i915_dsc_fec_support", 0644, root,
1603-
connector, &i915_dsc_fec_support_fops);
1602+
&connector->base, &i915_dsc_fec_support_fops);
16041603

16051604
debugfs_create_file("i915_dsc_bpc", 0644, root,
1606-
connector, &i915_dsc_bpc_fops);
1605+
&connector->base, &i915_dsc_bpc_fops);
16071606

16081607
debugfs_create_file("i915_dsc_output_format", 0644, root,
1609-
connector, &i915_dsc_output_format_fops);
1608+
&connector->base, &i915_dsc_output_format_fops);
16101609

16111610
debugfs_create_file("i915_dsc_fractional_bpp", 0644, root,
1612-
connector, &i915_dsc_fractional_bpp_fops);
1611+
&connector->base, &i915_dsc_fractional_bpp_fops);
16131612
}
16141613

1615-
if (connector->connector_type == DRM_MODE_CONNECTOR_DSI ||
1616-
connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
1617-
connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
1618-
connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
1619-
connector->connector_type == DRM_MODE_CONNECTOR_HDMIB)
1614+
if (connector_type == DRM_MODE_CONNECTOR_DSI ||
1615+
connector_type == DRM_MODE_CONNECTOR_eDP ||
1616+
connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
1617+
connector_type == DRM_MODE_CONNECTOR_HDMIA ||
1618+
connector_type == DRM_MODE_CONNECTOR_HDMIB)
16201619
debugfs_create_file("i915_lpsp_capability", 0444, root,
1621-
connector, &i915_lpsp_capability_fops);
1620+
&connector->base, &i915_lpsp_capability_fops);
16221621
}
16231622

16241623
/**

0 commit comments

Comments
 (0)