Skip to content

Commit 9274307

Browse files
Uwe Kleine-Königsudeep-holla
authored andcommitted
firmware: arm_ffa: Ensure drivers provide a probe function
The bus probe callback calls the driver callback without further checking. Better be safe than sorry and refuse registration of a driver without a probe function to prevent a NULL pointer exception. Link: https://lore.kernel.org/r/20210621201652.127611-1-u.kleine-koenig@pengutronix.de Fixes: e781858 ("firmware: arm_ffa: Add initial FFA bus support for device enumeration") Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
1 parent e73f0f0 commit 9274307

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

  • drivers/firmware/arm_ffa

drivers/firmware/arm_ffa/bus.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,9 @@ int ffa_driver_register(struct ffa_driver *driver, struct module *owner,
9999
{
100100
int ret;
101101

102+
if (!driver->probe)
103+
return -EINVAL;
104+
102105
driver->driver.bus = &ffa_bus_type;
103106
driver->driver.name = driver->name;
104107
driver->driver.owner = owner;

0 commit comments

Comments
 (0)