Skip to content

Commit 92f4ffe

Browse files
elkabloLorenzo Pieralisi
authored andcommitted
PCI: aardvark: Update comment about link going down after link-up
Update the comment about what happens when link goes down after we have checked for link-up. If a PIO request is done while link-down, we have a serious problem. Link: https://lore.kernel.org/r/20220110015018.26359-23-kabel@kernel.org Signed-off-by: Marek Behún <kabel@kernel.org> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
1 parent 0c36ab4 commit 92f4ffe

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

drivers/pci/controller/pci-aardvark.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -998,8 +998,12 @@ static bool advk_pcie_valid_device(struct advk_pcie *pcie, struct pci_bus *bus,
998998
return false;
999999

10001000
/*
1001-
* If the link goes down after we check for link-up, nothing bad
1002-
* happens but the config access times out.
1001+
* If the link goes down after we check for link-up, we have a problem:
1002+
* if a PIO request is executed while link-down, the whole controller
1003+
* gets stuck in a non-functional state, and even after link comes up
1004+
* again, PIO requests won't work anymore, and a reset of the whole PCIe
1005+
* controller is needed. Therefore we need to prevent sending PIO
1006+
* requests while the link is down.
10031007
*/
10041008
if (!pci_is_root_bus(bus) && !advk_pcie_link_up(pcie))
10051009
return false;

0 commit comments

Comments
 (0)