Skip to content

Commit 931a2ca

Browse files
arndbrostedt
authored andcommitted
arm64: ftrace: fix build error with CONFIG_FUNCTION_GRAPH_TRACER=n
It appears that a merge conflict ended up hiding a newly added constant in some configurations: arch/arm64/kernel/entry-ftrace.S: Assembler messages: arch/arm64/kernel/entry-ftrace.S:59: Error: undefined symbol FTRACE_OPS_DIRECT_CALL used as an immediate value FTRACE_OPS_DIRECT_CALL is still used when CONFIG_DYNAMIC_FTRACE_WITH_DIRECT_CALLS is enabled, even if CONFIG_FUNCTION_GRAPH_TRACER is disabled, so change the ifdef accordingly. Link: https://lkml.kernel.org/r/20230623152204.2216297-1-arnd@kernel.org Cc: Will Deacon <will@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Donglin Peng <pengdonglin@sangfor.com.cn> Fixes: 3646970 ("arm64: ftrace: Enable HAVE_FUNCTION_GRAPH_RETVAL") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Florent Revest <revest@chromium.org> Reviewed-by: Randy Dunlap <rdunlap@infradead.org> Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested Acked-by: Catalin Marinas <catalin.marinas@arm.com> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
1 parent 02b0095 commit 931a2ca

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

arch/arm64/kernel/asm-offsets.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,9 +213,9 @@ int main(void)
213213
DEFINE(FGRET_REGS_X7, offsetof(struct fgraph_ret_regs, regs[7]));
214214
DEFINE(FGRET_REGS_FP, offsetof(struct fgraph_ret_regs, fp));
215215
DEFINE(FGRET_REGS_SIZE, sizeof(struct fgraph_ret_regs));
216+
#endif
216217
#ifdef CONFIG_DYNAMIC_FTRACE_WITH_DIRECT_CALLS
217218
DEFINE(FTRACE_OPS_DIRECT_CALL, offsetof(struct ftrace_ops, direct_call));
218-
#endif
219219
#endif
220220
return 0;
221221
}

0 commit comments

Comments
 (0)