Skip to content

Commit 93bc4a5

Browse files
bvanasschemartinkpetersen
authored andcommitted
scsi: ufs: core: Rely on the block layer for setting RQF_PM
Do not set RQF_PM explicitly since scsi_alloc_request() sets it indirectly if BLK_MQ_REQ_PM is set. The call chain for the code that sets RQF_PM is as follows: scsi_alloc_request() blk_mq_alloc_request() __blk_mq_alloc_requests() blk_mq_rq_ctx_init() if (data->flags & BLK_MQ_REQ_PM) data->rq_flags |= RQF_PM; Link: https://lore.kernel.org/r/20230210193258.4004923-3-bvanassche@acm.org Cc: Mike Christie <michael.christie@oracle.com> Cc: John Garry <john.g.garry@oracle.com> Reviewed-by: John Garry <john.g.garry@oracle.com> Signed-off-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 35cd2f5 commit 93bc4a5

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/ufs/core/ufshcd.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9150,7 +9150,7 @@ static int ufshcd_execute_start_stop(struct scsi_device *sdev,
91509150
scmd->allowed = 0/*retries*/;
91519151
scmd->flags |= SCMD_FAIL_IF_RECOVERING;
91529152
req->timeout = 1 * HZ;
9153-
req->rq_flags |= RQF_PM | RQF_QUIET;
9153+
req->rq_flags |= RQF_QUIET;
91549154

91559155
blk_execute_rq(req, /*at_head=*/true);
91569156

0 commit comments

Comments
 (0)