vdpa/mlx5: Fix possible uninitialized return value

elic307i · mstsirkin · commit 93e530d2a1c4 · 2022-08-11T10:00:36.000-04:00
Initialize err local variable to return -EAGAIN if the asid cannot be found thus avoiding returning uninitialized value. Fixes: 8fcd20c ("vdpa/mlx5: Support different address spaces for control and data") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Eli Cohen <elic@nvidia.com> Message-Id: <20220811134010.952291-1-elic@nvidia.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
@@ -2659,7 +2659,7 @@ static int mlx5_vdpa_set_map(struct vdpa_device *vdev, unsigned int asid,
 {
 	struct mlx5_vdpa_dev *mvdev = to_mvdev(vdev);
 	struct mlx5_vdpa_net *ndev = to_mlx5_vdpa_ndev(mvdev);
-	int err;
+	int err = -EINVAL;
 
 	down_write(&ndev->reslock);
 	if (mvdev->group2asid[MLX5_VDPA_DATAVQ_GROUP] == asid) {

Original file line number	Diff line number	Diff line change
`@@ -2659,7 +2659,7 @@ static int mlx5_vdpa_set_map(struct vdpa_device *vdev, unsigned int asid,`
`2659`	`2659`	`{`
`2660`	`2660`	`struct mlx5_vdpa_dev *mvdev = to_mvdev(vdev);`
`2661`	`2661`	`struct mlx5_vdpa_net *ndev = to_mlx5_vdpa_ndev(mvdev);`
`2662`		`- int err;`
	`2662`	`+ int err = -EINVAL;`
`2663`	`2663`
`2664`	`2664`	`down_write(&ndev->reslock);`
`2665`	`2665`	`if (mvdev->group2asid[MLX5_VDPA_DATAVQ_GROUP] == asid) {`