Skip to content

Commit 9478c16

Browse files
airliedDanilo Krummrich
authored andcommitted
nouveau/gsp: drop WARN_ON in ACPI probes
These WARN_ONs seem to trigger a lot, and we don't seem to have a plan to fix them, so just drop them, as they are most likely harmless. Cc: stable@vger.kernel.org Fixes: 176fdcb ("drm/nouveau/gsp/r535: add support for booting GSP-RM") Signed-off-by: Dave Airlie <airlied@redhat.com> Link: https://patch.msgid.link/20241121014601.229391-1-airlied@gmail.com Signed-off-by: Danilo Krummrich <dakr@kernel.org>
1 parent e9e0b48 commit 9478c16

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

  • drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535

drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -737,8 +737,8 @@ r535_gsp_acpi_caps(acpi_handle handle, CAPS_METHOD_DATA *caps)
737737
if (!obj)
738738
goto done;
739739

740-
if (WARN_ON(obj->type != ACPI_TYPE_BUFFER) ||
741-
WARN_ON(obj->buffer.length != 4))
740+
if (obj->type != ACPI_TYPE_BUFFER ||
741+
obj->buffer.length != 4)
742742
goto done;
743743

744744
caps->status = 0;
@@ -773,8 +773,8 @@ r535_gsp_acpi_jt(acpi_handle handle, JT_METHOD_DATA *jt)
773773
if (!obj)
774774
goto done;
775775

776-
if (WARN_ON(obj->type != ACPI_TYPE_BUFFER) ||
777-
WARN_ON(obj->buffer.length != 4))
776+
if (obj->type != ACPI_TYPE_BUFFER ||
777+
obj->buffer.length != 4)
778778
goto done;
779779

780780
jt->status = 0;
@@ -861,8 +861,8 @@ r535_gsp_acpi_dod(acpi_handle handle, DOD_METHOD_DATA *dod)
861861

862862
_DOD = output.pointer;
863863

864-
if (WARN_ON(_DOD->type != ACPI_TYPE_PACKAGE) ||
865-
WARN_ON(_DOD->package.count > ARRAY_SIZE(dod->acpiIdList)))
864+
if (_DOD->type != ACPI_TYPE_PACKAGE ||
865+
_DOD->package.count > ARRAY_SIZE(dod->acpiIdList))
866866
return;
867867

868868
for (int i = 0; i < _DOD->package.count; i++) {

0 commit comments

Comments
 (0)