ALSA: kunit: make read-only array buf_samples static const

ColinIanKing · tiwai · commit 957a36c4fcf4 · 2024-04-26T17:07:01.000+02:00
Don't populate the read-only array buf_samples on the stack at
run time, instead make it static const.

Signed-off-by: Colin Ian King &lt;colin.i.king@gmail.com&gt;
Acked-by: Ivan Orlov &lt;ivan.orlov0322@gmail.com&gt;
Reviewed-by: Takashi Sakamoto &lt;o-takashi@sakamocchi.jp&gt;
Signed-off-by: Takashi Iwai &lt;tiwai@suse.de&gt;
Message-ID: &lt;20240425160754.114716-1-colin.i.king@gmail.com&gt;
diff --git a/sound/core/sound_kunit.c b/sound/core/sound_kunit.c
@@ -167,7 +167,7 @@ static void _test_fill_silence(struct kunit *test, struct snd_format_test_data *
 
 static void test_format_fill_silence(struct kunit *test)
 {
-	u32 buf_samples[] = { 10, 20, 32, 64, 129, SILENCE_BUFFER_MAX_FRAMES };
+	static const u32 buf_samples[] = { 10, 20, 32, 64, 129, SILENCE_BUFFER_MAX_FRAMES };
 	u8 *buffer;
 	u32 i, j;
 

Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,7 @@ static void _test_fill_silence(struct kunit test, struct snd_format_test_data `
`167`	`167`
`168`	`168`	`static void test_format_fill_silence(struct kunit *test)`
`169`	`169`	`{`
`170`		`- u32 buf_samples[] = { 10, 20, 32, 64, 129, SILENCE_BUFFER_MAX_FRAMES };`
	`170`	`+ static const u32 buf_samples[] = { 10, 20, 32, 64, 129, SILENCE_BUFFER_MAX_FRAMES };`
`171`	`171`	`u8 *buffer;`
`172`	`172`	`u32 i, j;`
`173`	`173`