Skip to content

Commit 958d614

Browse files
JasonXingPaolo Abeni
authored andcommitted
netrom: Fix a data-race around sysctl_netrom_default_path_quality
We need to protect the reader reading sysctl_netrom_default_path_quality because the value can be changed concurrently. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Jason Xing <kernelxing@tencent.com> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
1 parent 811b3f9 commit 958d614

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

net/netrom/nr_route.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ static int __must_check nr_add_node(ax25_address *nr, const char *mnemonic,
153153
nr_neigh->digipeat = NULL;
154154
nr_neigh->ax25 = NULL;
155155
nr_neigh->dev = dev;
156-
nr_neigh->quality = sysctl_netrom_default_path_quality;
156+
nr_neigh->quality = READ_ONCE(sysctl_netrom_default_path_quality);
157157
nr_neigh->locked = 0;
158158
nr_neigh->count = 0;
159159
nr_neigh->number = nr_neigh_no++;

0 commit comments

Comments
 (0)