Skip to content

Commit 95e4b25

Browse files
Dan Carpenterjwrdegoede
authored andcommitted
platform/mellanox: mlxbf-pmc: fix sscanf() error checking
The sscanf() function never returns negatives. It returns the number of items successfully read. Fixes: 1a218d3 ("platform/mellanox: mlxbf-pmc: Add Mellanox BlueField PMC driver") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Link: https://lore.kernel.org/r/4ccdfd28-099b-40bf-8d77-ad4ea2e76b93@kili.mountain Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
1 parent b54147f commit 95e4b25

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

drivers/platform/mellanox/mlxbf-pmc.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1348,9 +1348,8 @@ static int mlxbf_pmc_map_counters(struct device *dev)
13481348

13491349
for (i = 0; i < pmc->total_blocks; ++i) {
13501350
if (strstr(pmc->block_name[i], "tile")) {
1351-
ret = sscanf(pmc->block_name[i], "tile%d", &tile_num);
1352-
if (ret < 0)
1353-
return ret;
1351+
if (sscanf(pmc->block_name[i], "tile%d", &tile_num) != 1)
1352+
return -EINVAL;
13541353

13551354
if (tile_num >= pmc->tile_count)
13561355
continue;

0 commit comments

Comments
 (0)