Skip to content

Commit 961ac9d

Browse files
hbhilwarherbertx
authored andcommitted
crypto: qat - fix duplicate restarting msg during AER error
The restarting message from PF to VF is sent twice during AER error handling: once from adf_error_detected() and again from adf_disable_sriov(). This causes userspace subservices to shutdown unexpectedly when they receive a duplicate restarting message after already being restarted. Avoid calling adf_pf2vf_notify_restarting() and adf_pf2vf_wait_for_restarting_complete() from adf_error_detected() so that the restarting msg is sent only once from PF to VF. Fixes: 9567d3d ("crypto: qat - improve aer error reset handling") Signed-off-by: Harshita Bhilwaria <harshita.bhilwaria@intel.com> Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com> Reviewed-by: Ahsan Atta <ahsan.atta@intel.com> Reviewed-by: Ravikumar PM <ravikumar.pm@intel.com> Reviewed-by: Srikanth Thokala <srikanth.thokala@intel.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
1 parent b74fd80 commit 961ac9d

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

drivers/crypto/intel/qat/qat_common/adf_aer.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ static pci_ers_result_t adf_error_detected(struct pci_dev *pdev,
4141
adf_error_notifier(accel_dev);
4242
adf_pf2vf_notify_fatal_error(accel_dev);
4343
adf_dev_restarting_notify(accel_dev);
44-
adf_pf2vf_notify_restarting(accel_dev);
45-
adf_pf2vf_wait_for_restarting_complete(accel_dev);
4644
pci_clear_master(pdev);
4745
adf_dev_down(accel_dev);
4846

0 commit comments

Comments
 (0)