bcachefs: Fix ref in trans_mark_dev_sbs() error path

Kent Overstreet · Kent Overstreet · commit 9667214b30ef · 2024-05-20T05:37:26.000-04:00
Reported-by: syzbot+5c7f715a7107a608a544@syzkaller.appspotmail.com
Signed-off-by: Kent Overstreet &lt;kent.overstreet@linux.dev&gt;
diff --git a/fs/bcachefs/buckets.c b/fs/bcachefs/buckets.c
@@ -1465,7 +1465,7 @@ int bch2_trans_mark_dev_sbs_flags(struct bch_fs *c,
 	for_each_online_member(c, ca) {
 		int ret = bch2_trans_mark_dev_sb(c, ca, flags);
 		if (ret) {
-			bch2_dev_put(ca);
+			percpu_ref_put(&ca->io_ref);
 			return ret;
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -1465,7 +1465,7 @@ int bch2_trans_mark_dev_sbs_flags(struct bch_fs *c,`
`1465`	`1465`	`for_each_online_member(c, ca) {`
`1466`	`1466`	`int ret = bch2_trans_mark_dev_sb(c, ca, flags);`
`1467`	`1467`	`if (ret) {`
`1468`		`- bch2_dev_put(ca);`
	`1468`	`+ percpu_ref_put(&ca->io_ref);`
`1469`	`1469`	`return ret;`
`1470`	`1470`	`}`
`1471`	`1471`	`}`