drm/etnaviv: constify static struct cooling_ops

rikardfalkeborn · lynxeye-dev · commit 96894b795967 · 2021-12-01T13:27:51.000+01:00
The only usage of cooling_ops is to pass its address to
thermal_of_cooling_device_register(), which takes a pointer to const
struct thermal_cooling_device_ops as input. Make it const to allow the
compiler to put it in read-only memory.

Signed-off-by: Rikard Falkeborn &lt;rikard.falkeborn@gmail.com&gt;
Reviewed-by: Christian Gmeiner &lt;christian.gmeiner@gmail.com&gt;
Signed-off-by: Lucas Stach &lt;l.stach@pengutronix.de&gt;
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
@@ -1658,7 +1658,7 @@ etnaviv_gpu_cooling_set_cur_state(struct thermal_cooling_device *cdev,
 	return 0;
 }
 
-static struct thermal_cooling_device_ops cooling_ops = {
+static const struct thermal_cooling_device_ops cooling_ops = {
 	.get_max_state = etnaviv_gpu_cooling_get_max_state,
 	.get_cur_state = etnaviv_gpu_cooling_get_cur_state,
 	.set_cur_state = etnaviv_gpu_cooling_set_cur_state,

Original file line number	Diff line number	Diff line change
`@@ -1658,7 +1658,7 @@ etnaviv_gpu_cooling_set_cur_state(struct thermal_cooling_device *cdev,`
`1658`	`1658`	`return 0;`
`1659`	`1659`	`}`
`1660`	`1660`
`1661`		`-static struct thermal_cooling_device_ops cooling_ops = {`
	`1661`	`+static const struct thermal_cooling_device_ops cooling_ops = {`
`1662`	`1662`	`.get_max_state = etnaviv_gpu_cooling_get_max_state,`
`1663`	`1663`	`.get_cur_state = etnaviv_gpu_cooling_get_cur_state,`
`1664`	`1664`	`.set_cur_state = etnaviv_gpu_cooling_set_cur_state,`