Skip to content

Commit 96da8f1

Browse files
Qiang Ninglag-linaro
authored andcommitted
mfd: dln2: Fix memory leak in dln2_probe()
When dln2_setup_rx_urbs() in dln2_probe() fails, error out_free forgets to call usb_put_dev() to decrease the refcount of dln2->usb_dev. Fix this by adding usb_put_dev() in the error handling code of dln2_probe(). Signed-off-by: Qiang Ning <qning0106@126.com> Signed-off-by: Lee Jones <lee@kernel.org> Link: https://lore.kernel.org/r/20230330024353.4503-1-qning0106@126.com
1 parent 2405fbf commit 96da8f1

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/mfd/dln2.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -827,6 +827,7 @@ static int dln2_probe(struct usb_interface *interface,
827827
dln2_stop_rx_urbs(dln2);
828828

829829
out_free:
830+
usb_put_dev(dln2->usb_dev);
830831
dln2_free(dln2);
831832

832833
return ret;

0 commit comments

Comments
 (0)