Skip to content

Commit 970e1e4

Browse files
Ma Kewilldeacon
authored andcommitted
perf: arm_cspmu: fix error handling in arm_cspmu_impl_unregister()
driver_find_device() calls get_device() to increment the reference count once a matching device is found. device_release_driver() releases the driver, but it does not decrease the reference count that was incremented by driver_find_device(). At the end of the loop, there is no put_device() to balance the reference count. To avoid reference count leakage, add put_device() to decrease the reference count. Found by code review. Cc: stable@vger.kernel.org Fixes: bfc653a ("perf: arm_cspmu: Separate Arm and vendor module") Signed-off-by: Ma Ke <make24@iscas.ac.cn> Signed-off-by: Will Deacon <will@kernel.org>
1 parent 8fa08f8 commit 970e1e4

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/perf/arm_cspmu/arm_cspmu.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1407,8 +1407,10 @@ void arm_cspmu_impl_unregister(const struct arm_cspmu_impl_match *impl_match)
14071407

14081408
/* Unbind the driver from all matching backend devices. */
14091409
while ((dev = driver_find_device(&arm_cspmu_driver.driver, NULL,
1410-
match, arm_cspmu_match_device)))
1410+
match, arm_cspmu_match_device))) {
14111411
device_release_driver(dev);
1412+
put_device(dev);
1413+
}
14121414

14131415
mutex_lock(&arm_cspmu_lock);
14141416

0 commit comments

Comments
 (0)