fbdev: sm501fb: Convert sysfs snprintf to sysfs_emit

Xuezhi Zhang · hdeller · commit 9750737130dc · 2022-10-18T10:22:28.000+02:00
Follow the advice of the Documentation/filesystems/sysfs.rst
and show() should only use sysfs_emit() or sysfs_emit_at()
when formatting the value to be returned to user space.

Signed-off-by: Xuezhi Zhang &lt;zhangxuezhi1@coolpad.com&gt;
Signed-off-by: Helge Deller &lt;deller@gmx.de&gt;
diff --git a/drivers/video/fbdev/sm501fb.c b/drivers/video/fbdev/sm501fb.c
@@ -1166,7 +1166,7 @@ static ssize_t sm501fb_crtsrc_show(struct device *dev,
 	ctrl = smc501_readl(info->regs + SM501_DC_CRT_CONTROL);
 	ctrl &= SM501_DC_CRT_CONTROL_SEL;
 
-	return snprintf(buf, PAGE_SIZE, "%s\n", ctrl ? "crt" : "panel");
+	return sysfs_emit(buf, "%s\n", ctrl ? "crt" : "panel");
 }
 
 /* sm501fb_crtsrc_show

Original file line number	Diff line number	Diff line change
`@@ -1166,7 +1166,7 @@ static ssize_t sm501fb_crtsrc_show(struct device *dev,`
`1166`	`1166`	`ctrl = smc501_readl(info->regs + SM501_DC_CRT_CONTROL);`
`1167`	`1167`	`ctrl &= SM501_DC_CRT_CONTROL_SEL;`
`1168`	`1168`
`1169`		`- return snprintf(buf, PAGE_SIZE, "%s\n", ctrl ? "crt" : "panel");`
	`1169`	`+ return sysfs_emit(buf, "%s\n", ctrl ? "crt" : "panel");`
`1170`	`1170`	`}`
`1171`	`1171`
`1172`	`1172`	`/* sm501fb_crtsrc_show`