Skip to content

Commit 97a79de

Browse files
LuBaolujoergroedel
authored andcommitted
iommu/vt-d: Remove unnecessary check in intel_iommu_add()
The Intel IOMMU hot-add process starts from dmar_device_hotplug(). It uses the global dmar_global_lock to synchronize all the hot-add and hot-remove paths. In the hot-add path, the new IOMMU data structures are allocated firstly by dmar_parse_one_drhd() and then initialized by dmar_hp_add_drhd(). All the IOMMU units are allocated and initialized in the same synchronized path. There is no case where any IOMMU unit is created and then initialized for multiple times. This removes the unnecessary check in intel_iommu_add() which is the last reference place of the global IOMMU array. Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> Reviewed-by: Kevin Tian <kevin.tian@intel.com> Reviewed-by: Steve Wahl <steve.wahl@hpe.com> Link: https://lore.kernel.org/r/20220702015610.2849494-5-baolu.lu@linux.intel.com Signed-off-by: Joerg Roedel <jroedel@suse.de>
1 parent ba949f4 commit 97a79de

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

drivers/iommu/intel/iommu.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3460,9 +3460,6 @@ static int intel_iommu_add(struct dmar_drhd_unit *dmaru)
34603460
int sp, ret;
34613461
struct intel_iommu *iommu = dmaru->iommu;
34623462

3463-
if (g_iommus[iommu->seq_id])
3464-
return 0;
3465-
34663463
ret = intel_cap_audit(CAP_AUDIT_HOTPLUG_DMAR, iommu);
34673464
if (ret)
34683465
goto out;

0 commit comments

Comments
 (0)