Skip to content

Commit 97e176f

Browse files
hkallweitkuba-moo
authored andcommitted
r8169: add missing conditional compiling for call to r8169_remove_leds
Add missing dependency on CONFIG_R8169_LEDS. As-is a link error occurs if config option CONFIG_R8169_LEDS isn't enabled. Fixes: 19fa4f2 ("r8169: fix LED-related deadlock on module removal") Reported-by: Venkat Rao Bagalkote <venkat88@linux.vnet.ibm.com> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Tested-By: Venkat Rao Bagalkote <venkat88@linux.vnet.ibm.com> Link: https://lore.kernel.org/r/d080038c-eb6b-45ac-9237-b8c1cdd7870f@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 06dfcd4 commit 97e176f

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/net/ethernet/realtek/r8169_main.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5046,7 +5046,8 @@ static void rtl_remove_one(struct pci_dev *pdev)
50465046

50475047
cancel_work_sync(&tp->wk.work);
50485048

5049-
r8169_remove_leds(tp->leds);
5049+
if (IS_ENABLED(CONFIG_R8169_LEDS))
5050+
r8169_remove_leds(tp->leds);
50505051

50515052
unregister_netdev(tp->dev);
50525053

0 commit comments

Comments
 (0)