Skip to content

Commit 980ce2b

Browse files
GoodLuck612miquelraynal
authored andcommitted
mtd: parsers: Fix memory leak in mtd_parser_tplink_safeloader_parse()
The function mtd_parser_tplink_safeloader_parse() allocates buf via mtd_parser_tplink_safeloader_read_table(). If the allocation for parts[idx].name fails inside the loop, the code jumps to the err_free label without freeing buf, leading to a memory leak. Fix this by freeing the temporary buffer buf in the err_free label. Compile tested only. Issue found using a prototype static analysis tool and code review. Fixes: 00a3588 ("mtd: parsers: add TP-Link SafeLoader partitions table parser") Signed-off-by: Zilin Guan <zilin@seu.edu.cn> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
1 parent 125981f commit 980ce2b

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/mtd/parsers/tplink_safeloader.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ static int mtd_parser_tplink_safeloader_parse(struct mtd_info *mtd,
116116
return idx;
117117

118118
err_free:
119+
kfree(buf);
119120
for (idx -= 1; idx >= 0; idx--)
120121
kfree(parts[idx].name);
121122
err_free_parts:

0 commit comments

Comments
 (0)