Skip to content

Commit 98152eb

Browse files
Chaitanya KulkarniChristoph Hellwig
authored andcommitted
nvmet: use snprintf() with PAGE_SIZE in configfs
Instead of using sprintf, use snprintf with buffer size limited to PAGE_SIZE just like what we have for the rest of the file. Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com> Signed-off-by: Christoph Hellwig <hch@lst.de>
1 parent 73d77c5 commit 98152eb

1 file changed

Lines changed: 8 additions & 5 deletions

File tree

drivers/nvme/target/configfs.c

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,11 @@ static ssize_t nvmet_addr_adrfam_show(struct config_item *item, char *page)
6060

6161
for (i = 1; i < ARRAY_SIZE(nvmet_addr_family); i++) {
6262
if (nvmet_addr_family[i].type == adrfam)
63-
return sprintf(page, "%s\n", nvmet_addr_family[i].name);
63+
return snprintf(page, PAGE_SIZE, "%s\n",
64+
nvmet_addr_family[i].name);
6465
}
6566

66-
return sprintf(page, "\n");
67+
return snprintf(page, PAGE_SIZE, "\n");
6768
}
6869

6970
static ssize_t nvmet_addr_adrfam_store(struct config_item *item,
@@ -160,10 +161,11 @@ static ssize_t nvmet_addr_treq_show(struct config_item *item, char *page)
160161

161162
for (i = 0; i < ARRAY_SIZE(nvmet_addr_treq); i++) {
162163
if (treq == nvmet_addr_treq[i].type)
163-
return sprintf(page, "%s\n", nvmet_addr_treq[i].name);
164+
return snprintf(page, PAGE_SIZE, "%s\n",
165+
nvmet_addr_treq[i].name);
164166
}
165167

166-
return sprintf(page, "\n");
168+
return snprintf(page, PAGE_SIZE, "\n");
167169
}
168170

169171
static ssize_t nvmet_addr_treq_store(struct config_item *item,
@@ -281,7 +283,8 @@ static ssize_t nvmet_addr_trtype_show(struct config_item *item,
281283

282284
for (i = 0; i < ARRAY_SIZE(nvmet_transport); i++) {
283285
if (port->disc_addr.trtype == nvmet_transport[i].type)
284-
return sprintf(page, "%s\n", nvmet_transport[i].name);
286+
return snprintf(page, PAGE_SIZE,
287+
"%s\n", nvmet_transport[i].name);
285288
}
286289

287290
return sprintf(page, "\n");

0 commit comments

Comments
 (0)