Skip to content

Commit 987167b

Browse files
author
Maarten Lankhorst
committed
drm/xe: Privatize xe_ggtt_node
Nothing requires it any more, make the member private. Reviewed-by: Matthew Brost <matthew.brost@intel.com> Signed-off-by: Maarten Lankhorst <dev@lankhorst.se> Link: https://patch.msgid.link/20260108101014.579906-16-dev@lankhorst.se
1 parent 8d88aa1 commit 987167b

2 files changed

Lines changed: 19 additions & 18 deletions

File tree

drivers/gpu/drm/xe/xe_ggtt.c

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,24 @@
6767
* give us the correct placement for free.
6868
*/
6969

70+
/**
71+
* struct xe_ggtt_node - A node in GGTT.
72+
*
73+
* This struct needs to be initialized (only-once) with xe_ggtt_node_init() before any node
74+
* insertion, reservation, or 'ballooning'.
75+
* It will, then, be finalized by either xe_ggtt_node_remove() or xe_ggtt_node_deballoon().
76+
*/
77+
struct xe_ggtt_node {
78+
/** @ggtt: Back pointer to xe_ggtt where this region will be inserted at */
79+
struct xe_ggtt *ggtt;
80+
/** @base: A drm_mm_node */
81+
struct drm_mm_node base;
82+
/** @delayed_removal_work: The work struct for the delayed removal */
83+
struct work_struct delayed_removal_work;
84+
/** @invalidate_on_remove: If it needs invalidation upon removal */
85+
bool invalidate_on_remove;
86+
};
87+
7088
static u64 xelp_ggtt_pte_flags(struct xe_bo *bo, u16 pat_index)
7189
{
7290
u64 pte = XE_PAGE_PRESENT;

drivers/gpu/drm/xe/xe_ggtt_types.h

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
#include "xe_pt_types.h"
1212

1313
struct xe_bo;
14+
struct xe_ggtt_node;
1415
struct xe_gt;
1516

1617
/**
@@ -53,24 +54,6 @@ struct xe_ggtt {
5354
struct workqueue_struct *wq;
5455
};
5556

56-
/**
57-
* struct xe_ggtt_node - A node in GGTT.
58-
*
59-
* This struct needs to be initialized (only-once) with xe_ggtt_node_init() before any node
60-
* insertion, reservation, or 'ballooning'.
61-
* It will, then, be finalized by either xe_ggtt_node_remove() or xe_ggtt_node_deballoon().
62-
*/
63-
struct xe_ggtt_node {
64-
/** @ggtt: Back pointer to xe_ggtt where this region will be inserted at */
65-
struct xe_ggtt *ggtt;
66-
/** @base: A drm_mm_node */
67-
struct drm_mm_node base;
68-
/** @delayed_removal_work: The work struct for the delayed removal */
69-
struct work_struct delayed_removal_work;
70-
/** @invalidate_on_remove: If it needs invalidation upon removal */
71-
bool invalidate_on_remove;
72-
};
73-
7457
typedef void (*xe_ggtt_set_pte_fn)(struct xe_ggtt *ggtt, u64 addr, u64 pte);
7558
typedef void (*xe_ggtt_transform_cb)(struct xe_ggtt *ggtt,
7659
struct xe_ggtt_node *node,

0 commit comments

Comments
 (0)