SUNRPC: fix _xprt_switch_find_current_entry logic

olgakorn1 · amschuma-ntap · commit 98b4e5137504 · 2024-01-04T10:47:56.000-05:00
Fix the logic for picking current transport entry. Fixes: 95d0d30 ("SUNRPC create an iterator to list only OFFLINE xprts") Signed-off-by: Olga Kornievskaia <kolga@netapp.com> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
diff --git a/net/sunrpc/xprtmultipath.c b/net/sunrpc/xprtmultipath.c
@@ -284,7 +284,7 @@ struct rpc_xprt *_xprt_switch_find_current_entry(struct list_head *head,
 		if (cur == pos)
 			found = true;
 		if (found && ((find_active && xprt_is_active(pos)) ||
-			      (!find_active && xprt_is_active(pos))))
+			      (!find_active && !xprt_is_active(pos))))
 			return pos;
 	}
 	return NULL;

Original file line number	Diff line number	Diff line change
`@@ -284,7 +284,7 @@ struct rpc_xprt _xprt_switch_find_current_entry(struct list_head head,`
`284`	`284`	`if (cur == pos)`
`285`	`285`	`found = true;`
`286`	`286`	`if (found && ((find_active && xprt_is_active(pos)) \|\|`
`287`		`- (!find_active && xprt_is_active(pos))))`
	`287`	`+ (!find_active && !xprt_is_active(pos))))`
`288`	`288`	`return pos;`
`289`	`289`	`}`
`290`	`290`	`return NULL;`